Refactor python type inspection into a separate method. #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Johansen <[email protected]>
bkeryan
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Creates a separate method
_get_best_matching_type()that contains the unchanged logic to determine the type string to use when indexing into the_CONVERTER_FOR_PYTHON_TYPEset. No functionality has changed here.I also added a unit test for this new method.
Why should this Pull Request be merged?
I expect to be making changes to this python type inspection logic when working on converting to
Double2DArrayprotobuf objects. These changes will allow for nested containers. I would like the logic I plan to change to be in a separate method with unit tests so I know I'm not breaking anything, and also so I can make faster iterations during development.Related to AB#3166107
What testing has been done?
Unit tests, mypy, styleguide.